iamsanjay commented on code in PR #2247:
URL: https://github.com/apache/solr/pull/2247#discussion_r1484968409
##########
solr/core/src/java/org/apache/solr/search/CacheConfig.java:
##########
@@ -177,8 +177,8 @@ public SolrCache newInstance() {
@Override
public Map<String, Object> toMap(Map<String, Object> argsMap) {
- argsMap.putAll(args);
- return argsMap;
+ // TODO: Should not create new HashMap?
Review Comment:
I can't say for sure, which is why I decided to revert it back. I found the
pull request that introduced it; it needed more careful inspection.
https://issues.apache.org/jira/browse/SOLR-14155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
