[
https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815302#comment-17815302
]
Sanjay Dutt commented on SOLR-16505:
------------------------------------
I came across updateExecutor object in UpdateShardHandler.java.
{code:java}
private ExecutorService updateExecutor =
new ExecutorUtil.MDCAwareThreadPoolExecutor(
0,
Integer.MAX_VALUE,
60L,
TimeUnit.SECONDS,
new SynchronousQueue<>(),
new SolrNamedThreadFactory("updateExecutor"),
// the Runnable added to this executor handles all exceptions so we disable
stack trace
// collection as an optimization
// see SOLR-11880 for more details
false);{code}
*I wonder why we did not used this executor while initializing the
`Http2SolrClient.Builder()` for*
{*}updateOnlyClient{*}. Instead used, the default executor provided by the
builder. But then we have two Executors – one for Update requests and another
one internal use. But earlier, before introducing http2 client for update, we
had one executor for both.
Default Executor from builder
{code:java}
this.executor =
new ExecutorUtil.MDCAwareThreadPoolExecutor(
32, 256, 60, TimeUnit.SECONDS, queue, new SolrNamedThreadFactory("h2sc"));{code}
> Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2
> ------------------------------------------------------------------
>
> Key: SOLR-16505
> URL: https://issues.apache.org/jira/browse/SOLR-16505
> Project: Solr
> Issue Type: Sub-task
> Reporter: David Smiley
> Priority: Major
>
> This method and its callers (only RecoveryStrategy) should be converted to a
> Jetty HTTP2 client.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
