magibney commented on PR #2293: URL: https://github.com/apache/solr/pull/2293#issuecomment-1965252700
I guess just because the results are +/- analogous to SolrDocuments results, in terms of serialized output. numFound, etc. For the purpose of this PR I was trying to leave that unchanged. I think the baggage with serialization is less from the "SolrDocuments" approach _per se_, and more around the exact way in which the initial PR went about constructing the SolrDocuments to be immutable (since they are reused across multiple requests). The biggest problem with the initial PR really was its use of `doc.getFieldValueMap()`, which afaict (I belatedly realize) seems not designed to be used outside of a test context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
