gerlowskija commented on code in PR #2293:
URL: https://github.com/apache/solr/pull/2293#discussion_r1548479721
##########
solr/core/src/test/org/apache/solr/logging/TestLogWatcher.java:
##########
@@ -104,4 +121,56 @@ public void testLog4jWatcher() throws InterruptedException
{
oldMessages.add(msg);
}
}
+
+ /**
+ * Here we validate that serialization works as expected for several
different methods. Ideally we
+ * would use actual serialization from Jersey/Jackson, since this is what
really happens in V2
+ * APIs. But this is simpler, and should give us roughly equivalent
assurances.
+ */
Review Comment:
Apologies for not seeing this sooner @magibney
I like what you have here, for a "unit" level test.
The alternative would be to test this higher up - say, by using
SolrJettyTestCase and using SolrJ to hit the v2 logging API. That'd test the
serialization by virtue of testing the whole endpoint.
But I like your more-specific approach here better 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
