jdyer1 opened a new pull request, #2402: URL: https://github.com/apache/solr/pull/2402
This adds a standard `CompletableFuture`-based API to `Http2SolrClient`, `HttpJdkSolrClient` and `LBHttp2SolrClient`. The existing methods `asyncReq` are marked `@deprecated` and defer to the new API methods. Also deprecated are interfaces `AsyncListener` and `Cancellable`. Uses within Solr of these deprecated methods/interfaces are migrated to the new API. Also test coverage for these async methods is improved. This is based loosely on [PR 1770](https://github.com/apache/lucene-solr/pull/1770). This PR does not add async methods to `CloudHttp2SolrClient`, neither does it attempt to unify the async API between `LBHttp2SolrClient` and `Http2SolrClient`. There are several TODOs around `LBHttpSolrClient` & `LBHttp2SolrClient` to investigate and fix possible bugs and improve test coverage. These TODOs are beyond the scope of this PR. Once merged, we should follow-up with a separate PR to remove the deprecated methods and interfaces in main/Solr10 only. cc: [rishisankar](https://github.com/rishisankar) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
