dsmiley commented on code in PR #2402:
URL: https://github.com/apache/solr/pull/2402#discussion_r1564234192
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##########
@@ -299,7 +299,9 @@ public void testAsyncException() throws Exception {
public void testAsyncAndCancel() throws Exception {
String url = getBaseUrl() + DEBUG_SERVLET_PATH;
Http2SolrClient.Builder b =
- new Http2SolrClient.Builder(url).withResponseParser(new
XMLResponseParser());
+ new Http2SolrClient.Builder(url)
+ .withConnectionTimeout(DEFAULT_CONNECTION_TIMEOUT,
TimeUnit.MILLISECONDS)
Review Comment:
Not sure if this is out of scope; tied to the other thing you agreed should
be separate. A minor matter anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
