dsmiley commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1561815614
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -384,6 +384,9 @@ private static NodeConfig
fillSolrSection(NodeConfig.NodeConfigBuilder builder,
log.warn("solr.xml transientCacheSize -- transient cores is
deprecated");
builder.setTransientCacheSize(it.intVal(-1));
break;
+ case "allowPartialResultsDefault":
+ builder.setAllowPartialResultsDefault(it.boolVal(true));
+ break;
Review Comment:
I would prefer you not bother with all the machinery in solr.xml/NodeConfig
and instead have a simple EnvUtils (env or sys prop) to enable. It's just a
boolean; doesn't have any interesting config to it. Yes there are other
booleans here but I think we Solr maintainers should consider how NodeConfig
might systematically / dynamically understand primitive values (boolean,
integer, ...) and apply to EnvUtils automatically without having to touch the
NodeConfig class (which is kind of a pain; that builder!). For example imagine
"solr.search.partialResults" being settable as a system property, or also
settable in solr.xml automatically via "searchPartialResults".
CC @janhoy
Another take on this is that, shouldn't the user simply go to their
solrconfig.xml and set a default partialResults like we all do for
miscellaneous things for search?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
