sigram commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1565966780


##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -384,6 +384,9 @@ private static NodeConfig 
fillSolrSection(NodeConfig.NodeConfigBuilder builder,
                 log.warn("solr.xml transientCacheSize -- transient cores is 
deprecated");
                 builder.setTransientCacheSize(it.intVal(-1));
                 break;
+              case "allowPartialResultsDefault":
+                builder.setAllowPartialResultsDefault(it.boolVal(true));
+                break;

Review Comment:
   I agree, IMHO having a per-collection setting instead of a global sysprop is 
more flexible (and you can still change it globally using property 
substitution).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to