epugh commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1568013748
##########
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java:
##########
@@ -215,8 +215,9 @@ public NamedList<Object> request(SolrRequest<?> request,
String coreName)
if (handler == null) {
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "unknown
handler: " + path);
}
-
- req = _parser.buildRequestFrom(core, params, getContentStreams(request));
+ req =
+ _parser.buildRequestFrom(
Review Comment:
I wonder, should we have still have a _parser.buildRequestFrom() that
doesn't require the user principal? These days, do we need to make sure that
every method has a user principal? Maybe what I am asking is, are there lots
of other places where, if you enable basic auth, then you get errors because
the oroginal code didn't plan for that?
##########
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##########
@@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {
String configName = "solrCloudCollectionConfig";
int nodeCount = 5;
- configureCluster(nodeCount).addConfig(configName, configDir).configure();
+
+ final String SECURITY_JSON =
Review Comment:
Starting to feel like `SECURITY_JSON` needs to be moved into some sort of
cross cutting concern/utility method as we see this basic code proliferate more
and more ;-). Don't get me wrong, I think it's great we are testing our code
with Basic Auth more!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
