rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1581277776
##########
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##########
@@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {
String configName = "solrCloudCollectionConfig";
int nodeCount = 5;
- configureCluster(nodeCount).addConfig(configName, configDir).configure();
+
+ final String SECURITY_JSON =
Review Comment:
Quick update -- my comment from last week mentioned some unresolved
questions about what happens when security.json has the setting
`forwardCredentials=false`. I've redone my manual testing and am no longer
seeing a failure in that case, so I'm guessing the earlier problem was a result
of some temporary code changes that never got committed. In manual testing I'm
now seeing subqueries work properly regardless of whether `forwardCredentials`
is true or false, so I'm not thinking of this as an unresolved item anymore.
Regarding the consolidation of SECURITY_JSON across the test suite, I'm
looking for guidance on whether to do it here or whether it could be done in a
separate PR. My preference would be to do it separately so this current PR can
stay small and manageable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
