dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1575500892
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -845,6 +852,13 @@ public static class Builder
protected Long keyStoreReloadIntervalSecs;
+ public Http2SolrClient.Builder
withListenerFactory(List<HttpListenerFactory> listenerFactory) {
Review Comment:
@epugh I know you worked on SolrClient immutability efforts. Here, specific
to Http2SolrClient, the "listenerFactory" list can now be set on the builder.
The setter should probably also be marked Deprecated. Do you think this should
be separated to another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
