dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1593008731
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -115,6 +115,11 @@ public class Http2SolrClient extends HttpSolrClientBase {
private SSLConfig sslConfig;
private List<HttpListenerFactory> listenerFactory = new ArrayList<>();
+
+ public List<HttpListenerFactory> getListenerFactory() {
Review Comment:
Minor, but this getter is very misplaced. It shouldn't be placed amidst the
fields.
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##########
@@ -587,5 +587,27 @@ public void testBuilder() {
}
}
+ @Test
+ public void testIdleTimeoutWithHttpClient() {
Review Comment:
nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
