andywebb1975 opened a new pull request, #2433:
URL: https://github.com/apache/solr/pull/2433

   https://issues.apache.org/jira/browse/SOLR-17263
   
   # Description
   
   HttpJdkSolrClient doesn't encode curly braces etc
   
   # Solution
   
   Use SolrParams' toQueryString() method rather than implicitly using 
toString() which doesn't encode all chars.
   
   NB I'm not sure this is a comprehensive fix - there may be further instances 
to change - and I'm not sure about the `bodyPublisher` line change.
   
   # Tests
   
   (none yet)
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to