andywebb1975 commented on code in PR #2433:
URL: https://github.com/apache/solr/pull/2433#discussion_r1596932930
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientTestBase.java:
##########
@@ -337,24 +347,27 @@ protected void testCollectionParameters(
protected void setReqParamsOf(UpdateRequest req, String... keys) {
if (keys != null) {
for (String k : keys) {
- req.setParam(k, k + "Value");
+ // note inclusion of non-ASCII character, and curly quotes which
should be URI encoded
+ req.setParam(k, k + "Value\u1234{}");
}
}
}
- protected void verifyServletState(HttpSolrClientBase client, SolrRequest<?>
request) {
+ protected void verifyServletState(HttpSolrClientBase client, SolrRequest<?>
request) throws Exception {
// check query String
Iterator<String> paramNames =
request.getParams().getParameterNamesIterator();
while (paramNames.hasNext()) {
String name = paramNames.next();
String[] values = request.getParams().getParams(name);
if (values != null) {
+ // this can be enabled to see the raw query string (it's not expected
to be an empty string!)
+ // assertEquals("", DebugServlet.queryString);
Review Comment:
I've not found myself re-enabling this line - the raw query string appears
in the log for failures anyway. Removing it for now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
