dsmiley commented on code in PR #2432:
URL: https://github.com/apache/solr/pull/2432#discussion_r1586807196
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##########
@@ -181,29 +183,46 @@ public String getShardId(String nodeName, String
coreName) {
}
public String getShardId(String collectionName, String nodeName, String
coreName) {
Review Comment:
Sorry; I defintiely don't think we should hold ourselves to that high of a
standard. As you know there are a ton of classes and methods that are public
in all of SolrJ JARs. The risk of *not* giving ourselves permission to remove
stuff is that contributions that might come, instead do not because it's too
much work to maintain backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
