dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2100741552
The most important part of Http2SolrClient to be re-used (instead of
re-created) is Jetty's HttpClient. Creating another Http2SolrClient that uses
an existing HttpClient isn't too bad but yeah it'd be nice if we didn't have to
re-create one. This PR is an improvement! IndexFetcher.getLatestVersion,
fetchFileList, getStream, and getDetails not only re-use the underlying
HttpClient, as before, but now use the SolrClient wrapper, which is more
succinct & simple in so doing.
Some thoughts on the commit message summarizing this long one:
- UpdateShardHandler
- switch "recoveryOnlyHttpClient" to Http2SolrClient
- RecoveryStrategy:
- Use Http2SolrClient
- Simplify cancelation of prep recovery command
- IndexFetcher:
- Use Http2SolrClient
- Ensure the entire stream is consumed to avoid a connection reset
- Http2SolrClient:
- make HttpListenerFactory configurable (used for internal purposes)
It's unclear if there was any change with respect to gzip /
"useExternalCompression" -- this part of the diff is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
