iamsanjay commented on code in PR #2351:
URL: https://github.com/apache/solr/pull/2351#discussion_r1596314264
##########
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##########
@@ -236,11 +246,17 @@ public SolrMetricsContext getSolrMetricsContext() {
return solrMetricsContext;
}
- // if you are looking for a client to use, it's probably this one.
+ // please use getDefaultHttpSolrClient instead.
+ @Deprecated(since = "9.6")
public HttpClient getDefaultHttpClient() {
return defaultClient;
}
+ // if you are looking for a client to use, it's probably this one.
Review Comment:
1. Okay so no delegating to SolrClientCache.
2. Creating `CoreContainer#getDefaultHttpSolrClient` and delegating it to
`UpdateShardHandler` can be one option(I will add code for this!)
3. If we are thinking of name change that would requires changes at around
40 places in the codebase as per quick search.
Some new names suggestions as per AI:
HttpOperationManager
HttpExecutorCollection
MultiHttpClientHandler
HttpTaskCoordinator
HttpOperationCoordinator
HttpClientManager
HttpTaskManager
4. We can also create Default HTTP client inside the CoreContainer. On the
other hand, CoreContainer already have too much, Not sure If want to give them
more.
5. Or may be it's time to divide UpdateShardHandler to few more classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
