gus-asf commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-2115586822

   The discussion on this is long, so maybe I've missed it, but the actual 
merged code has introduced the possibility (though I suspect it might never 
happen) of a non-numeric Max Score...
   
   ````
       public float getMaxScore(int totalHits) {
         if (totalHits > 0) {
           for (Object res : result) {
             if (res instanceof MaxScoreResult) {
               return ((MaxScoreResult) res).maxScore;
             }
           }
           return Float.NaN;    <<<<<<<<<<<<<<<<<<<<<<
         } else {
           return 0.0f;
         }
       }
   ````
   Did I miss discussion of this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to