iamsanjay commented on code in PR #2501:
URL: https://github.com/apache/solr/pull/2501#discussion_r1642032024
##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -389,7 +389,7 @@ private void doWebMode() {
numPagesPosted = postWebPages(args, 0, out);
info(numPagesPosted + " web pages indexed.");
- } catch (MalformedURLException e) {
+ } catch (URISyntaxException e) {
Review Comment:
I started using `URI.create` for the same reason that you just explained as
it throws unchecked exception which allows us to avoid explicitly handling the
`URISyntaxException`.
Should we switch to `new URI` wherever we can without changing too much? I
am open to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
