uschindler commented on code in PR #2501:
URL: https://github.com/apache/solr/pull/2501#discussion_r1643031425
##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -389,7 +389,7 @@ private void doWebMode() {
numPagesPosted = postWebPages(args, 0, out);
info(numPagesPosted + " web pages indexed.");
- } catch (MalformedURLException e) {
+ } catch (URISyntaxException e) {
Review Comment:
> I have replaced the `URI.create` with `new URI` in `PostTool.java`. Also
replaced in few test classes as well.
Actually you did this everywhere, which I am not sure if its a good idea. In
PostTool i recommend to change this to get a consistent error message in both
cases: for original URI and for the appendUrlPath() method.
I am not a big fan of checked Exceptions, so I would have used new URI only
to make it consistent with the code around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
