cpoerschke commented on code in PR #2524:
URL: https://github.com/apache/solr/pull/2524#discussion_r1644860246
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -403,14 +403,9 @@ public void process(ResponseBuilder rb) throws IOException
{
req.getContext().put(SolrIndexSearcher.STATS_SOURCE, statsCache.get(req));
- QueryResult result = new QueryResult();
-
cmd.setSegmentTerminateEarly(
params.getBool(
CommonParams.SEGMENT_TERMINATE_EARLY,
CommonParams.SEGMENT_TERMINATE_EARLY_DEFAULT));
- if (cmd.getSegmentTerminateEarly()) {
- result.setSegmentTerminatedEarly(Boolean.FALSE);
- }
Review Comment:
observation: deferring this bit also helps with the `// not supported,
silently ignore any segmentTerminateEarly flag` bit at lines 420/421 415/416
below i.e. if the results have `Boolean.FALSE` in future then it would not be
despite the silent ignoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
