cpoerschke commented on code in PR #2524:
URL: https://github.com/apache/solr/pull/2524#discussion_r1644863482
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -421,22 +416,22 @@ public void process(ResponseBuilder rb) throws
IOException {
cmd.setSegmentTerminateEarly(false);
try {
if (params.getBool(GroupParams.GROUP_DISTRIBUTED_FIRST, false)) {
- doProcessGroupedDistributedSearchFirstPhase(rb, cmd, result);
+ doProcessGroupedDistributedSearchFirstPhase(rb, cmd);
return;
} else if (params.getBool(GroupParams.GROUP_DISTRIBUTED_SECOND,
false)) {
- doProcessGroupedDistributedSearchSecondPhase(rb, cmd, result);
+ doProcessGroupedDistributedSearchSecondPhase(rb, cmd);
return;
}
- doProcessGroupedSearch(rb, cmd, result);
+ doProcessGroupedSearch(rb, cmd);
Review Comment:
subjective/style: if/since we're changing this code area, how about adding a
`else { }` wrap and then removing the two `return;` in the first and second
phases?
```suggestion
else {
doProcessGroupedSearch(rb, cmd);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
