psalagnac commented on code in PR #2538:
URL: https://github.com/apache/solr/pull/2538#discussion_r1686889090
##########
solr/core/src/java/org/apache/solr/util/stats/MetricUtils.java:
##########
@@ -827,7 +845,7 @@ public static <T extends PlatformManagedObject> void
addMXBeanMetrics(
try {
final Class<? extends PlatformManagedObject> intf =
Class.forName(clazz).asSubclass(PlatformManagedObject.class);
- MetricUtils.addMXBeanMetrics(obj, intf, null, consumer);
+ MetricUtils.addMXBeanMetrics(obj, intf, prefix, consumer);
Review Comment:
I forgot to comment on this when creating the pull request.
I think this was a typo when this code was initially added. The `prefix`
parameter of the method is not passed through to the other method. In practice,
all callers to `addMXBeanMetrics()` in Solr code set null for this parameter,
so this will not change anything.
Another option could be to just remove the parameter, but I think it's
better to keep it if we have later more categories for metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
