dsmiley commented on PR #2598:
URL: https://github.com/apache/solr/pull/2598#issuecomment-2253134832
I did a search for RAMDirectoryFactory in source code to look for other
possible issues, and I see what may be a bigger challenge in
`org.apache.solr.SolrTestCaseJ4#initCore()`.
```
factoryProp = System.getProperty("solr.directoryFactory");
if (factoryProp == null) {
System.setProperty("solr.directoryFactory",
"solr.RAMDirectoryFactory");
}
```
Your change means that factoryProp is going to be null when previously it
would not have been. I suppose we can simply remove this? I like that... but
admittedly it means that tests that do *not* use the test files you refer to
would previously have used MockDirectoryFactory but now will get
RAMDirectoryFactory. I suppose you'll just have to triage any failures with
this in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
