gerlowskija commented on PR #2598:
URL: https://github.com/apache/solr/pull/2598#issuecomment-2258662980
Actually it looks like removing the check in `SolrTestCaseJ4.initCore()`
causes a number of tests to fail, mostly with SecurityManager-related
exceptions.
Taking `SolrCoreTest.testCoreInitDeadlockMetrics` as an example, it uses
`core/src/test-files/configsets/minimal/` to create a core. The relevant
directoryFactory config there is:
```
<directoryFactory name="DirectoryFactory"
class="${solr.directoryFactory:solr.NRTCachingDirectoryFactory}"/>
```
As things stand on 'main'/'branch_9x' currently, the gradle randomization
ensures that `solr.directoryFactory` is always set to be MockDF, so the
"default" value in this snippet doesn't ever come into play. But in the most
recent iteration of this PR neither `randomization.gradle` nor
`SolrTestCaseJ4.initCore()` set a default dirFactory, so the test will start
using NRTCachingDirectoryFactory and fail as a result.
I'm gonna try to go through and update the dirFactory default to MockDF in
'minimal' and some of these other lingering configsets, in the knowledge that
these solrconfig.xml defaults were all being overridden by the
randomization.gradle logic anyways. But if I run into any issues I might
rollback and put the `SolrTestCaseJ4.initCore()` back in place...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
