epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765232692
##########
solr/packaging/test/test_healthcheck.bats:
##########
@@ -29,8 +29,9 @@ teardown() {
}
@test "healthcheck on cloud solr" {
- solr start -c -e films
- run solr healthcheck -c films
+ solr start -c -e films -p ${SOLR_PORT}
+ run solr healthcheck -c films -zkhost localhost:${ZK_PORT} -V
refute_output --partial 'error'
Review Comment:
so, when I added a `--partial 'ERROR'` it didn't help because we actually
put that message out in a legitimate run! So I backed out that change.
There is a path where the healthcheck fails at the Java layer, and writes out
"ERROR", and we don't see that due to our refute. I guess a better approach
is to look for positive things ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
