epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765266710
##########
solr/core/src/java/org/apache/solr/cli/ToolBase.java:
##########
@@ -34,18 +34,29 @@ protected ToolBase(PrintStream stdout) {
}
protected void echoIfVerbose(final String msg, CommandLine cli) {
- if (cli.hasOption(SolrCLI.OPTION_VERBOSE.getOpt())) {
+ if (verbose) {
echo(msg);
}
}
+ /**
+ * Is this tool being run in a verbose mode?
+ *
+ * @return verbose or not
Review Comment:
sure... my javadoc looks pretty skinny with no `@return`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
