malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1779488758
##########
solr/core/src/java/org/apache/solr/cli/Tool.java:
##########
@@ -52,5 +53,7 @@ default String getFooter() {
List<Option> getOptions();
+ List<OptionGroup> getOptionGroups();
Review Comment:
I know this PR is a draft, but is it eventually better to go for `Options
getOptions()` instead of `getOptions()` and `getOptionGroups()`? If a list is
needed `Options#getOptions()` may be used instead.
`Options#addOptions(Options options)` does also exist if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
