malliaridis commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2455611441
> I go back and forth on making everything a Java object.
cli.getOption("my-option") to me reads better than cli.getOption(MY_OPTION)
I agree on that, but I also feel that having long and short variants of
options makes `cli.getOption("my-option") kinda confusing. And it has proven to
be also error-prone when working with strings. Forgetting to update a referene
is easier with strings than with object references. This is probably the most
important reason to go for objects.
> Is this for branch_9x as well???
No, 9x would require all the deprecated options as well, resulting to
`OptionGroup`s. If we make a completely different PR we could introduce similar
changes, but backporting won't do here withot breaking backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
