[
https://issues.apache.org/jira/browse/SOLR-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895443#comment-17895443
]
ASF subversion and git services commented on SOLR-17456:
--------------------------------------------------------
Commit e849fd0540fb4f0e013a1f73e93c3e85a933ed83 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=e849fd0540f ]
SOLR-17456: TransactionLog ctor integrity (#2762)
The TransactionLog constructor can't handle an existing file being present; it
shouldn't be there.
Should throw an exception in this case, NOT log a warning which would leave the
object in a partially constructed state.
This should happen in the first place, of course. I see no evidence it has
occurred.
> TransactionLog NPE
> ------------------
>
> Key: SOLR-17456
> URL: https://issues.apache.org/jira/browse/SOLR-17456
> Project: Solr
> Issue Type: Bug
> Reporter: David Smiley
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In an erroneous case, a TransactionLog should throw an exception if an
> unexpected log file exists instead of merely log a warning in its
> constructor. The latter leaves the file in a partially constructed state
> that leads to NPEs when it's used later.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
