[ 
https://issues.apache.org/jira/browse/SOLR-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895446#comment-17895446
 ] 

ASF subversion and git services commented on SOLR-17390:
--------------------------------------------------------

Commit c5c538a9e025bda77ad591ee82beaa6a6732c408 in solr's branch 
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c5c538a9e02 ]

SOLR-17390: EmbeddedSolrServer now considers the ResponseParser (#2774)

And
* Moved HttpSolrCall.getResponseWriter to SolrQueryRequest
* Subtle improvements to make ContentStream work when they might not have

> EmbeddedSolrServer should support a ResponseParser
> --------------------------------------------------
>
>                 Key: SOLR-17390
>                 URL: https://issues.apache.org/jira/browse/SOLR-17390
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> By default, a SolrRequest has a null/unspecified ResponseParser; it's handled 
> automatically within SolrJ.  But an explicit one communicates an intent for 
> the client code to need it, like JsonMapResponseParser, 
> InputStreamResponseParser, or NoOpResponseParser (particularly those 3).  
> EmbeddedSolrServer doesn't look at this; the NamedList right out of the 
> core/handler is normalized (via javabin round-trip) and returned.  While that 
> makes sense _normally_, a ResponseParser should also be supported.  This 
> enables tests that might want to use EmbeddedSolrServer but that which need 
> to test JSON or XML (for convenience of xpath/json expressions, for example). 
>  Also, the newer V2 API generated clients would need this to support 
> EmbeddedSolrServer as they are currently based off of 
> InputStreamResponseParser.
> Doing this means determining the correct ResponseWriter (not assuming JavaBin 
> during normalization).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to