malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1830112416
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -569,7 +564,7 @@ private void updateIncludeFileEnableAuth(
includeFileLines.add("REM The following lines added by solr.cmd for
enabling BasicAuth");
includeFileLines.add("set SOLR_AUTH_TYPE=kerberos");
includeFileLines.add(
- "set SOLR_AUTHENTICATION_OPTS=\"-Dsolr.httpclient.config=" +
basicAuthConfFile + "\"");
+ "set
SOLR_AUTHENTICATION_OPTS=\"-Dsolr.httpclient.config=basicAuthConfFile\"");
Review Comment:
Ah, I see. I paid little attention to the surrounding code. Maybe it is
better then to add brackets or leave it blank to make it clear that this has to
be filled out? Because a value like `basicAuthConfFile` looks like an enum
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
