[
https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898441#comment-17898441
]
James Dyer commented on SOLR-17541:
-----------------------------------
Is this controversial? Can we choose to make the Jetty LB Client maintain
multiple immutable client instances with the base url preset, as the deprecated
client does? In light of SOLR-17256 this seems to be the path forward, and
would let us remove some of the complexity this last change introduced.
> LBSolrClient implementations should agree on 'getClient()' semantics
> ---------------------------------------------------------------------
>
> Key: SOLR-17541
> URL: https://issues.apache.org/jira/browse/SOLR-17541
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 9.7
> Reporter: Jason Gerlowski
> Priority: Minor
>
> LBSolrClient has an abstract "getClient(String url)" method that is used to
> fetch a "Http" SolrClient appropriate for the specified URL.
> But implementations of this method differ in the client that is returned.
> LBHttpSolrClient returns a client that is already pointed at the specified
> URL and can be used without modification. But LBHttp2SolrClient returns a
> client with no URL altogether, that must be pointed at the right endpoint
> prior to use. This is a bit messy, and complicates the calling code in
> LBSolrClient quite a bit.
> We should choose one of these approaches and use it for all LBSolrClient
> implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
