[
https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907898#comment-17907898
]
ASF subversion and git services commented on SOLR-17541:
--------------------------------------------------------
Commit bc94ca3012de98752d88e8cd7ba3f4e4ac75ac66 in solr's branch
refs/heads/branch_9x from James Dyer
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=bc94ca3012d ]
SOLR-17541: Deprecate Http2SolrClient.Builder#withListenerFactory &
CloudHttpSolrClient.Builder#withHttpClient (only)
> LBSolrClient implementations should agree on 'getClient()' semantics
> ---------------------------------------------------------------------
>
> Key: SOLR-17541
> URL: https://issues.apache.org/jira/browse/SOLR-17541
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 9.7
> Reporter: Jason Gerlowski
> Assignee: James Dyer
> Priority: Minor
> Labels: pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> LBSolrClient has an abstract "getClient(String url)" method that is used to
> fetch a "Http" SolrClient appropriate for the specified URL.
> But implementations of this method differ in the client that is returned.
> LBHttpSolrClient returns a client that is already pointed at the specified
> URL and can be used without modification. But LBHttp2SolrClient returns a
> client with no URL altogether, that must be pointed at the right endpoint
> prior to use. This is a bit messy, and complicates the calling code in
> LBSolrClient quite a bit.
> We should choose one of these approaches and use it for all LBSolrClient
> implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
