epugh commented on code in PR #2856:
URL: https://github.com/apache/solr/pull/2856#discussion_r1845468260
##########
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##########
@@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
String coreRootDirectory; // usually same as solr home, but not always
- Map<String, Object> systemInfo =
- solrClient
- .request(new GenericSolrRequest(SolrRequest.METHOD.GET,
CommonParams.SYSTEM_INFO_PATH))
- .asMap();
Review Comment:
You are right that I don't like NamedList, it's always been a weird Solr
specific data structure. Why did we feel the need to come up with a unique
data structure that isn't in the JDK? Having said that, what you are
proposing is clearly an improvement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
