dsmiley commented on code in PR #2856:
URL: https://github.com/apache/solr/pull/2856#discussion_r1845543227
##########
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##########
@@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
String coreRootDirectory; // usually same as solr home, but not always
- Map<String, Object> systemInfo =
- solrClient
- .request(new GenericSolrRequest(SolrRequest.METHOD.GET,
CommonParams.SYSTEM_INFO_PATH))
- .asMap();
Review Comment:
I think @gerlowskija would argue that the "perfect world" (we're slowly
iterating towards) would not be JSON at this level of abstraction, it'd be a a
machine-generated POJO generated from our OpenAPI that you call normal typed
methods on. Correct me if I'm wrong Jason; I agree with that vision too.
But in the meantime Eric, get to know NamedList. It's not going anywhere
anytime soon, and it's also not hard to use IMO. I wish it had the convenience
methods that SolrParams has but not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
