malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860765555
##########
solr/core/src/java/org/apache/solr/search/FunctionQParser.java:
##########
@@ -398,7 +398,7 @@ protected ValueSource parseValueSource(int flags) throws
SyntaxError {
if ((ch >= '0' && ch <= '9') || ch == '.' || ch == '+' || ch == '-') {
Number num = sp.getNumber();
if (num instanceof Long) {
- valueSource = new
ValueSourceParser.LongConstValueSource(num.longValue());
+ valueSource = new
ValueSourceParsers.LongConstValueSource(num.longValue());
Review Comment:
This one is actually interesting. The other two value sources are from
Lucene, `LongConstValueSource` is from Solr, which is why this is inconsistent.
I could add an import, but perhaps something else could be considered here?
Would `ConstValueSource` be the equivalent in Lucene for `long` values?
Because I can only find `ConstValueSource` for `double` in Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
