malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860801651
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -1128,9 +1131,9 @@ protected SolrCore(
initIndex(prev != null, reload);
initWriters();
- qParserPlugins.init(QParserPlugin.standardPlugins, this);
- valueSourceParsers.init(ValueSourceParser.standardValueSourceParsers,
this);
- transformerFactories.init(TransformerFactory.defaultFactories, this);
+ qParserPlugins.init(QParserPlugins.standardPlugins, this);
Review Comment:
Some tests outside the core package currently use these registries,
including:
- `org.apache.solr.cloud.TestRandomFlRTGCloud` (ref. transformers)
- `org.apache.solr.search.QueryEqualityTest` (ref. value source parsers and
query parser plugins)
- `org.apache.solr.search.TestStandardQParsers` (ref. query parser plugins)
- `org.apache.solr.search.SignificantTermsQParserPluginTest` (ref. query
parser plugins)
From the logical grouping perspective it makes sense to me to keep them in
the current packages. From the visibility perspective (public API) I would
prefer to make them package-private / internal.
Perhaps its best to keep it as is for now until we introduce an
auto-discovery feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
