mlbiscoc commented on PR #2907: URL: https://github.com/apache/solr/pull/2907#issuecomment-2542818507
> Really excited about this refactoring! I made some comments, mostly around "hey, this is a nice chnage" or "hey, is this an opporutnity" versus "please change this" type comments. > > One thing I am curious is how do we know all the conversions are done? I like the addition of the TODO to point out where more refactorings can be done. I guess I am wondering, once we have a lot of `.toString()` or `.toPath()`, how do we go back and remove the excess conversion loops? Also, i wonder if we need to add when this is done some forbiddenapi entries for file? I triggered the CI process... hopefully CI will run on all your other commits. Thanks for helping review @epugh! I found all imports of `java.io.File` and tried to remove it as much as possible. Mostly tried to fix using File if it was trival, otherwise you'll see the `toFile()` or `toPath() This is a first pass through and looks like tests pass. Second pass would probably be to try and remove `toFile()` or `toPath()` as well as creation of any `new File()` as much as possible. If we can make it a forbidden API, the build will tell us where all of them are being called to continue with clean up. I found the File api was used so much in Tests, when I was doing conversions the number of lines changes became too much for this PR. I am holding those on my fork for now and hopefully I can maybe push that PR after this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
