dsmiley commented on code in PR #2907:
URL: https://github.com/apache/solr/pull/2907#discussion_r1887546435
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
Review Comment:
nice!
##########
solr/core/src/java/org/apache/solr/util/FileUtils.java:
##########
@@ -55,16 +54,16 @@ public static void copyFile(File src, File destination)
throws IOException {
* @param fullFile the File to be synced to disk
* @throws IOException if the file could not be synced
*/
- public static void sync(File fullFile) throws IOException {
- if (fullFile == null || !fullFile.exists())
+ public static void sync(Path fullFile) throws IOException {
Review Comment:
now remove the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
