gerlowskija commented on PR #2912: URL: https://github.com/apache/solr/pull/2912#issuecomment-2558115243
> Still need to look into David's question about use of `Instant` Alright - the main hiccup for using `Instant` is that it's not supported by our serialization layer. Jackson supports it pretty easily on the v2 side, but our v1 "ResponseWriter"-based serialization code doesn't. (The v1 code needs support because of how our v1 APIs are built "on top of" the v2 APIs - "primitive" types used in the v2 POJO end up in the NamedList that the v1 code serializes out.) Anyway, I think it would be nice to support this, but I don't want to squeeze it into this PR so I'm not tempted to skimp on testing, etc. I've filed [a ticket for it](https://issues.apache.org/jira/browse/SOLR-17608), and hope to pursue that shortly. In the meantime I added 'TODO' comments to the places David flagged as being 'Instant'-ready - we can circle back to those either as a part of SOLR-17608, or once it's done. (FYI @dsmiley ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
