gerlowskija commented on code in PR #2912: URL: https://github.com/apache/solr/pull/2912#discussion_r1895185494
########## solr/api/src/java/org/apache/solr/client/api/endpoint/SegmentsApi.java: ########## Review Comment: Fwiw, we've already got some reuse here: e.g. [these SegmentsApi constants](https://github.com/apache/solr/pull/2912/files#diff-b26451021791966580a1c1416f23f66067ccc636be6c09a8c62486b95255ec36R36-R49) get re-used in CollectionStatusApi as well. The main thing that prevents us from doing something more with inheritance, etc. is that the method signatures for CollectionStatusApi/SegmentsApi aren't the same. The CollectionStatusApi method takes two parameters ('collectionName' and 'segments') that have no SegmentApi equivalent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
