HoustonPutman commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2613152878
> As there is now FieldExistsQuery covering a range of cases (not just even docValues & norms), this probably obsoletes complexity inside FieldType.getExistenceQuery. Can we just call that and remove getSpecializedExistenceQuery as needless in lieu of subtypes overriding getExistenceQuery? > > CC @HoustonPutman as you worked on this method It looks like the range of cases are just docValues, norms and vectors. Not sure we can get rid of much of the complexity. `getSpecializedExistenceQuery` is still necessary for double/float fields without docValues or norms. and Spatial fields. I think this just moves the three query classes into one class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
