cpoerschke commented on code in PR #2632:
URL: https://github.com/apache/solr/pull/2632#discussion_r1932657684
##########
solr/core/src/java/org/apache/solr/schema/CurrencyFieldType.java:
##########
@@ -387,7 +386,7 @@ private Query getRangeQueryInternal(
(p1 != null) ? p1.getCurrencyCode() : (p2 != null) ?
p2.getCurrencyCode() : defaultCurrency;
// ValueSourceRangeFilter doesn't check exists(), so we have to
- final Query docsWithValues = new
DocValuesFieldExistsQuery(getAmountField(field).getName());
+ final Query docsWithValues =
getAmountField(field).getType().getExistenceQuery(parser, field);
Review Comment:
Able to reproduce the `./gradlew test --tests CurrencyFieldTypeTest` test
failure locally, shall we go back to `FieldExistsQuery` here maybe, or perhaps
the test needs revising (haven't looked).
```suggestion
final Query docsWithValues = new
FieldExistsQuery(getAmountField(field).getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
