cpoerschke commented on PR #3224:
URL: https://github.com/apache/solr/pull/3224#issuecomment-2690119802
Thinking about how the changes in this PR might be described in
`solr/CHANGES.txt` ...
... so the user with a custom component with a custom distributed stage is
still left in a _"must have and configure a custom SearchHandler that overrides
the `stageInEnglish` method"_ scenario ...
... might overriding be supported and yet could the base implementation use
something like "CUSTOM_42" for a custom stage with value 42?
And looking at how the `stageInEnglish` method is called, perhaps
```
private static boolean checkLimitsBefore(
SearchComponent c,
- String when,
+ Supplier<String> when,
SolrQueryRequest req,
SolrQueryResponse resp,
List<SearchComponent> components) {
```
could also be considered i.e. for `stageInEnglish` to be only actually
called when a limit is exceeded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
