jeanielamwh commented on PR #3224: URL: https://github.com/apache/solr/pull/3224#issuecomment-2690449959
> ... might overriding be supported and yet could the base implementation use something like "CUSTOM_42" for a custom stage with value 42? I like this idea. Otherwise, it seems a bit excessive to me that a user with custom stages must override this method that's used for logging only. Pushed [be8e468](https://github.com/apache/solr/pull/3224/commits/be8e46872e6e3bddaa30a4824db399643fabadff) to replace the throw with returning `CUSTOM_STAGE_<NUM>`. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
