epugh commented on code in PR #3236:
URL: https://github.com/apache/solr/pull/3236#discussion_r1980146287
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -148,7 +148,7 @@ public static void main(String[] args) {
.argName("BASE_URL")
.type(String.class)
.desc(
- "Specify the Solr base URL when connecting to Solr in
standalone mode. If omitted both the -b parameter and the -z parameter, connect
to http://localhost:8983/solr. For example 'http://localhost:8983/solr'.")
+ "Specify the Solr base URL when connecting to Solr in
standalone mode. If omitted both the -s parameter and the -z parameter, connect
to http://localhost:8983/solr. For example 'http://localhost:8983/solr'.")
Review Comment:
do we actually need the `/solr`? I know in the main SolrCLI we don't
mention `/solr` becasue it can ALSO be `/api` depending on what end points you
are hitting. This may be a bit different! Also, if you look at `bin/solr`
we have some stuff to populate environment variables that are read by
`CLIUtils.getDefaultSolrUrl()`.. `solr.tool.host` .. I wonder if we should be
reusing that here? Though maybe that is really for another PR?
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -241,7 +241,7 @@ public static void main(String[] args) {
.argName("ZK_HOST")
.type(String.class)
.desc(
- "Specify the ZooKeeper connection string when connecting to
Solr in SolrCloud mode. If omitted both the -b parameter and the -z parameter,
connect to http://localhost:8983/solr. For example 'localhost:2181/solr'.")
+ "Specify the ZooKeeper connection string when connecting to
Solr in SolrCloud mode. If omitted both the -s parameter and the -z parameter,
connect to http://localhost:8983/solr. For example 'localhost:2181/solr'.")
Review Comment:
One more though, we do have in `ToolBase.java` the `public OptionGroup
getConnectionOptions` that defines these options... Though to use that, maybe
the SolrExporter would need to be a direct part of `SolrCLI`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
