epugh commented on code in PR #3236:
URL: https://github.com/apache/solr/pull/3236#discussion_r1994384208
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -349,4 +361,31 @@ private static MetricsConfiguration
loadMetricsConfiguration(String configPath)
private static String getSystemVariable(String name) {
return System.getProperty(name, System.getenv(name));
}
+
+ // copied over from CLIUtils
+ public static void exit(int exitStatus) {
+ try {
+ System.exit(exitStatus);
+ } catch (java.lang.SecurityException secExc) {
+ if (exitStatus != 0)
+ throw new RuntimeException("SolrExporter failed to exit with status "
+ exitStatus);
+ }
+ }
+
+ // copied over from CLIUtils
+ private static String getDefaultSolrUrl() {
+ // note that ENV_VAR syntax (and the env vars too) are mapped to env.var
sys props
+ String scheme = EnvUtils.getProperty("solr.url.scheme", "http");
+ String host = EnvUtils.getProperty("solr.tool.host", "localhost");
Review Comment:
I just commited to 10x (only) the change to remove solr.tool.host.
backporting to 9x was tough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
