dsmiley commented on code in PR #3248:
URL: https://github.com/apache/solr/pull/3248#discussion_r1987289810
##########
solr/core/src/test/org/apache/solr/handler/admin/ShowFileRequestHandlerTest.java:
##########
@@ -100,18 +100,15 @@ public String getWriterType() {
}
@Override
- public NamedList<Object> processResponse(InputStream body, String
encoding) {
- try {
- if (body.read() >= 0) readFile.set(true);
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
+ public NamedList<Object> processResponse(InputStream body, String
encoding)
+ throws IOException {
+ if (body.read() >= 0) readFile.set(true);
return null;
}
@Override
- public NamedList<Object> processResponse(Reader reader) {
- throw new UnsupportedOperationException("TODO unimplemented"); //
TODO
+ public Set<String> getContentTypes() {
+ return Set.of(); // don't enforce
Review Comment:
The file diff is confusing here because what was removed and added have
nothing to do with each other. Two things are happening here:
(1) removed processResponse(Reader) from ResponseParser and thus the
implementation in this file need not implement (it was compelled to before)
(2) getContentTypes is now abstract and so all implementations must implement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
