dsmiley commented on code in PR #3248:
URL: https://github.com/apache/solr/pull/3248#discussion_r1987307957
##########
solr/core/src/test/org/apache/solr/response/TestRawTransformer.java:
##########
@@ -283,12 +283,7 @@ public void testJsonTransformer() throws Exception {
strResponse.contains("\"links\":[\""));
}
- private static final NoOpResponseParser XML_NOOP_RESPONSE_PARSER = new
NoOpResponseParser();
+ private static final NoOpResponseParser XML_NOOP_RESPONSE_PARSER = new
NoOpResponseParser("xml");
private static final NoOpResponseParser JSON_NOOP_RESPONSE_PARSER =
- new NoOpResponseParser() {
- @Override
- public String getWriterType() {
- return "json";
- }
- };
+ new NoOpResponseParser("json");
Review Comment:
no; all these words really add up and it barely line wraps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
